Do not propagate module_map and umbrella_headers of objc private deps #1056
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-golub
requested review from
BalestraPatrick,
brentleyjones,
keith,
segiddins,
thii and
mattrobmattrob
as code owners
ivan-golub
force-pushed
the
ig/private_modulemaps_umbrellas
branch
5 times, most recently
from
68bca45
to
3adfe46
Compare
ivan-golub
force-pushed
the
ig/private_modulemaps_umbrellas
branch
from
3adfe46
to
0004e22
Compare
|
Can you add tests to verify this behavior so we don't regress it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1055
Same as https://github.com/bazelbuild/bazel/pull/17962/files#diff-8018fc7b6b2243557d777851745b3d96af6b6df682593308c8ba4f110fedfce7R73-R90